From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/i2c: Track users of GMBUS force-bit
Date: Tue, 13 Nov 2012 16:12:26 +0100
Message-ID: <20121113151225.GS5854@phenom.ffwll.local>
References: <1352563101-1701-1-git-send-email-chris@chris-wilson.co.uk>
	<878va5va6o.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 29A219EC2F
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Nov 2012 07:11:10 -0800 (PST)
Received: by mail-ea0-f177.google.com with SMTP id n13so2866835eaa.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Nov 2012 07:11:10 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <878va5va6o.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Nov 13, 2012 at 04:39:43PM +0200, Jani Nikula wrote:
> On Sat, 10 Nov 2012, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > @@ -583,7 +583,10 @@ void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit)
> >  {
> >  	struct intel_gmbus *bus = to_intel_gmbus(adapter);
> >  
> > -	bus->force_bit = force_bit;
> > +	bus->force_bit += force_bit ? 1 : -1;
> > +	DRM_DEBUG_KMS("%sabling bit-banging on %s. force bit now %d\n",
> > +		      force_bit ? "dis" : "en", adapter->name,
> > +		      bus->force_bit);
> 
> Reading a dmesg from Chris, I noticed force_bit ? "dis" : "en" is
> backwards.

Thanks for spotting this, rebase out, it never happened.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch