From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Only check for valid PP_{ON,
 OFF}_DELAYS on pre ILK hardware
Date: Thu, 15 Nov 2012 15:42:08 +0100
Message-ID: <20121115144208.GX5854@phenom.ffwll.local>
References: <1351711396-6373-1-git-send-email-damien.lespiau@gmail.com>
	<CA+gsUGTmFo0bDyHRZBb1QdQW8ANZCzH9ka5oaUGUJEoKzQ0Kyw@mail.gmail.com>
	<CAKMK7uHjt45iWrmWHRtDvLOSk8OtRyxoo19GxUTcJqdVCE84Cg@mail.gmail.com>
	<CA+gsUGSQxNWQEaaERXqYA6ZJBWnBsau-qMcGg=gGhH=mQxxHBg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 244EA9E92B
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 15 Nov 2012 06:40:50 -0800 (PST)
Received: by mail-ee0-f49.google.com with SMTP id c1so995908eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 15 Nov 2012 06:40:50 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGSQxNWQEaaERXqYA6ZJBWnBsau-qMcGg=gGhH=mQxxHBg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Nov 15, 2012 at 12:33:59PM -0200, Paulo Zanoni wrote:
> Hi
> 
> 2012/11/1 Daniel Vetter <daniel@ffwll.ch>:
> > On Thu, Nov 1, 2012 at 4:52 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> >> The only problem is: we're not doing anything here for the
> >> HAS_PCH_SPLIT platforms. Shouldn't we be doing something? We do have
> >> eDP code to set the PCH_PP registers, but not LVDS code for this.
> >> Also, each encoder probably needs different values.
> >>
> >> So my suggestion would be: apply this patch (since it fixes a problem)
> >> and then, in the future, maybe, move this code to the encoder-specific
> >> callbacks, and also consider the HAS_PCH_SPLIT + LVDS case.
> >
> > It's even worse than that: This code is also run on ums setups, so
> > potentially we could break some old setups here ...
> 
> I certainly understand how the suggestion I made may break the UMS
> setup, so I really think we can "drop" my suggestion, but I see no
> reason to drop the original patch, since it just avoids writing a
> register that does not exist (giving us less error messages on
> Haswell). Maybe this patch was just forgotten?

Indeed, patch is now merged to dinq, thanks for the prod
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch