From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Use LRI to update the semaphore registers Date: Tue, 20 Nov 2012 16:37:33 +0100 Message-ID: <20121120153733.GL5854@phenom.ffwll.local> References: <1352884515-10154-1-git-send-email-chris@chris-wilson.co.uk> <20121114110642.397ca341@bwidawsk.net> <20121115091448.7d1c5782@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D4FE0E62A2 for ; Tue, 20 Nov 2012 07:36:12 -0800 (PST) Received: by mail-ea0-f177.google.com with SMTP id c10so649948eaa.36 for ; Tue, 20 Nov 2012 07:36:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <20121115091448.7d1c5782@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Daniel J Blueman List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 15, 2012 at 09:14:48AM -0800, Ben Widawsky wrote: > On Wed, 14 Nov 2012 11:06:42 -0800 > Ben Widawsky wrote: > > > On Wed, 14 Nov 2012 09:15:14 +0000 > > Chris Wilson wrote: > > > > > The bspec was recently updated to remove the ability to update the > > > semaphore using the MI_SEMAPHORE_BOX command, the ability to wait upon > > > the semaphore value remained. Instead the advice is to update the > > > register using the MI_LOAD_REGISTER_IMM command. In cursory testing, > > > semaphores continue to function - the question is whether this fixes > > > some of the deadlocks where the semaphore registers contained stale > > > values? > > > > > > Signed-off-by: Chris Wilson > > > Cc: Daniel J Blueman > > Reviewed-by: Ben Widawsky > Tested-by: Ben Widawsky I seem to have forgotten to mention that this is merged. Bad, bad me ... Thanks for the patch & review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch