From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Use pci_resource functions for BARs. Date: Wed, 21 Nov 2012 15:58:25 +0100 Message-ID: <20121121145825.GU5854@phenom.ffwll.local> References: <1353355496-1067-1-git-send-email-ben@bwidawsk.net> <1353356624-15873-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E6D26E649E for ; Wed, 21 Nov 2012 06:57:05 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so2384284eek.36 for ; Wed, 21 Nov 2012 06:57:05 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Nov 19, 2012 at 09:27:13PM +0000, Chris Wilson wrote: > On Mon, 19 Nov 2012 12:23:44 -0800, Ben Widawsky wrote: > > This was leftover crap from kill-agp. The current code is theoretically > > broken for 64b bars. (I resist removing theoretically because I am too > > lazy to test). > > > > We still need to ioremap things ourselves because we want to ioremap_wc > > the PTEs. > > > > v2: Forgot to kill the tmp variable in v1 > > > > CC: Chris Wilson > > Signed-off-by: Ben Widawsky > > Nice. > > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch