Re: [PATCH 2/2] drm/i915/sdvo: kfree the intel_sdvo_connector, not drm_connector, on destroy

Daniel Vetter
2012-11-22T13:09:10Z

On Mon, Nov 12, 2012 at 06:31:36PM +0200, Jani Nikula wrote:
> Since the base fields in both struct intel_connector and struct
> intel_sdvo_connector are at the beginning of the enclosing struct, the
> pointers are essentially the same, but there is no requirement or guarantee
> that this is always the case. Kfree the enclosing intel_sdvo_connector
> pointer that was originally allocated, not the enclosed drm_connector, in
> case someone ever rearranges the structs.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch