From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Ensure that the wait ioctl return timeout is valid Date: Thu, 29 Nov 2012 13:42:17 +0100 Message-ID: <20121129124217.GK3202@phenom.ffwll.local> References: <1352920285-26149-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 02CFCE658E for ; Thu, 29 Nov 2012 04:40:52 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so6432875eek.36 for ; Thu, 29 Nov 2012 04:40:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1352920285-26149-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 14, 2012 at 07:11:24PM +0000, Chris Wilson wrote: > Due to a discrepancy between the sleep time and the amount of time we > spend waiting inside the wait_event_timeout, it is possible that we end > up computing that negative time remains in the wait_ioctl. This is > obviously a bogus result to return to userspace, and triggers a WARN, so > we need to fix up the value before propagating it back. > > Signed-off-by: Chris Wilson > Cc: Ben Widawsky Ben, can you pls take a look at this and smash an r-b on it if you're ok? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch