From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup sparse warnings
Date: Mon, 3 Dec 2012 22:35:51 +0100
Message-ID: <20121203213550.GP4384@phenom.ffwll.local>
References: <1354223932-8278-1-git-send-email-daniel.vetter@ffwll.ch>
	<84c8a8$6pr9bk@orsmga001.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id AE8EFE5C14
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  3 Dec 2012 13:34:24 -0800 (PST)
Received: by mail-ee0-f49.google.com with SMTP id c4so1895222eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 03 Dec 2012 13:34:24 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <84c8a8$6pr9bk@orsmga001.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Dec 03, 2012 at 09:13:52PM +0000, Chris Wilson wrote:
> On Thu, 29 Nov 2012 22:18:51 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > - __iomem where there is none (I love how we mix these things up).
> > - Use gfp_t instead of an other plain type.
> > - Unconfuse one place about enum pipe vs enum transcoder - for the pch
> >   transcoder we actually use the pipe enum. Fixup the other cases
> >   where we assign the pipe to the cpu transcoder with explicit casts.
> > - Declare the mch_lock properly in a header.
> > 
> > There is still a decent mess in intel_bios.c about __iomem, but heck,
> > this is x86 and we're allowed to do that.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Makes-sparse-happy: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, applied, with the cast in i915_irq.c fixed, too.
> 
> How about deciding whether it is '(cast) object' or '(cast)object' and
> be consistent.

Seems to be inconstent, randomly picked space.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch