From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 10/10] drm/i915: rip out update_linetime_wm
 abstraction
Date: Wed, 5 Dec 2012 12:03:40 +0100
Message-ID: <20121205110340.GK11556@phenom.ffwll.local>
References: <1354201179-14975-1-git-send-email-daniel.vetter@ffwll.ch>
	<1354201179-14975-10-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGRkhFe-jgMoyVqv+Sn=evC_60QuPYtApLMTqM+FnSshsg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1A6ECE5EB5
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  5 Dec 2012 03:02:12 -0800 (PST)
Received: by mail-ee0-f49.google.com with SMTP id c4so2849391eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 05 Dec 2012 03:02:12 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGRkhFe-jgMoyVqv+Sn=evC_60QuPYtApLMTqM+FnSshsg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Dec 04, 2012 at 03:34:09PM -0200, Paulo Zanoni wrote:
> Hi
> 
> 2012/11/29 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > I like abstraction and vfuncs, but only if they actually abstract anything.
> > In this case here they just obfuscate, so let's rip this stuff out.
> >
> > Aside: We really should move all the haswell stuff into it's own file ...
> 
> Well, a few Kernels ago we did a nice effort to move a lot of code
> from intel_display.c to intel_pm.c. Now we're bringing it back... I'd
> like to understand what are the current plans regarding this.

I guess we should move all the haswell stuff into intel_ddi.c, once it
settles. But I'll drop the watermark patches here anyway, not thought
through these here ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch