From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 07/10] drm/i915: extract common link_m_n helpers Date: Thu, 6 Dec 2012 14:33:33 +0100 Message-ID: <20121206133333.GS11556@phenom.ffwll.local> References: <1354201179-14975-1-git-send-email-daniel.vetter@ffwll.ch> <1354201179-14975-7-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 751E7E6684 for ; Thu, 6 Dec 2012 05:32:05 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so3618565eek.36 for ; Thu, 06 Dec 2012 05:32:04 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Dec 03, 2012 at 01:33:29PM -0200, Paulo Zanoni wrote: > 2012/11/29 Daniel Vetter : > > Both the dp and fdi code use the exact same computations (ignore minor > > differences in conversion between bits and bytes). > > > > This makes it even more apparent that we have a _massive_ mess between > > cpu transcoder/fdi link/pch transcoder and pch link settings. And also > > that we have hilarious amounts of confusion between edp and dp > > (despite that they're identical at a link level). > > > > Signed-off-by: Daniel Vetter > > Reviewed-by: Paulo Zanoni Slurped in the DP part of this patch-bomb, the watermark stuff isn't really thought through. Thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch