From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Reduce memory pressure during shrinker by preallocating swizzle pages Date: Fri, 7 Dec 2012 01:16:39 +0100 Message-ID: <20121207001639.GX11556@phenom.ffwll.local> References: <20121203191827.GO4384@phenom.ffwll.local> <1354568594-26504-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B43DE5C60 for ; Thu, 6 Dec 2012 16:15:10 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so3962956eek.36 for ; Thu, 06 Dec 2012 16:15:09 -0800 (PST) Content-Disposition: inline In-Reply-To: <1354568594-26504-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Dec 03, 2012 at 09:03:14PM +0000, Chris Wilson wrote: > On a machine with bit17 swizzling, we need to store the bit17 of the > physical page address in put-pages. This requires a memory allocation, > on average less than a page, which may be difficult to satisfy is the > request to put-pages is on behalf of the shrinker. We could allow that > allocation to pull from the reserved memory pools, but it seems much > safer to preallocate the array for tiled objects on affected machines. > > v2: Export i915_gem_object_needs_bit17_swizzle() for reuse. > > Signed-off-by: Chris Wilson Missed this one here buried in another thread. Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch