From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: set the LPT FDI RX polarity
 reversal bit when needed
Date: Mon, 10 Dec 2012 10:38:47 +0100
Message-ID: <20121210093847.GK11556@phenom.ffwll.local>
References: <1354370666-3802-1-git-send-email-przanoni@gmail.com>
	<1354370666-3802-4-git-send-email-przanoni@gmail.com>
	<CAPX-8+8B+Vq7K9bzKMSkC3GdDd_eztqhNMhwvB9CNcHun4em2w@mail.gmail.com>
	<CA+gsUGTbgiHHVu+CnTz2WPGDMks_UBE9tgCBYmT-R5j8Mc=big@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3DADFE5EEA
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 10 Dec 2012 01:37:16 -0800 (PST)
Received: by mail-ee0-f49.google.com with SMTP id c4so1389890eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 10 Dec 2012 01:37:15 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGTbgiHHVu+CnTz2WPGDMks_UBE9tgCBYmT-R5j8Mc=big@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Dec 09, 2012 at 07:37:40PM -0200, Paulo Zanoni wrote:
> Hi
> 
> 2012/12/8 Damien Lespiau <damien.lespiau@intel.com>:
> > On Sat, Dec 1, 2012 at 2:04 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> If we fail to set the bit when needed we get some nice FDI link
> >> training failures (AKA "black screen on VGA output").
> >>
> >> While we don't really know how to properly choose whether we need to
> >> set the bit or not (VBT?), just read the initial value set by the BIOS
> >> and store it for later usage.
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > Sad that we did not catch that before. It's not just the polarity
> > (support for exchanging the - and + wires on a differential pair), but
> > also the FDI lane reversal (0 becomes 3, 1 becomes 2) setting that we
> > need to preserve. There's a fused bit for the DMI lane reversal and
> > FDI defaults to following that DMI lane reversal configuration, but we
> > also have a bit to override that behaviour in the FDI RX register, we
> > need to preserve this bit  as well.
> 
> They're different problems and require different patches. This one
> fixes the "FDI RX polarity" problem, not "lane reversal".

Picked up for -fixes (together with patch 1), thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch