From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: clean up PIPECONF bpc #defines Date: Mon, 17 Dec 2012 14:22:05 +0100 Message-ID: <20121217132205.GN5737@phenom.ffwll.local> References: <1355739698-20392-1-git-send-email-daniel.vetter@ffwll.ch> <87k3shdjaw.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 82EF0E5C84 for ; Mon, 17 Dec 2012 05:20:32 -0800 (PST) Received: by mail-wg0-f45.google.com with SMTP id dq12so2547883wgb.12 for ; Mon, 17 Dec 2012 05:20:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <87k3shdjaw.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Dec 17, 2012 at 01:12:07PM +0200, Jani Nikula wrote: > On Mon, 17 Dec 2012, Daniel Vetter wrote: > > Ilk+ somehow used #defines in near the PIPESTAT definitions, which > > decently confused me. Earlier platforms called it BPP instead of > > BPC. Clean this all up. > > This patch does what it says on the box, so > > Reviewed-by: Jani Nikula Queued for -next, thanks for the review. > *BUT* see a related comment below. Discussed on irc, Haswell has now completely separate paths so comment doesn't apply any longer. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch