From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915: Add DEBUG messages to all intel_create_user_framebuffer error paths Date: Wed, 19 Dec 2012 13:47:41 +0200 Message-ID: <20121219114741.GS29018@intel.com> References: <1355868794-3708-1-git-send-email-chris@chris-wilson.co.uk> <1355868794-3708-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 287ECE5C76 for ; Wed, 19 Dec 2012 03:47:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1355868794-3708-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Dec 18, 2012 at 10:13:14PM +0000, Chris Wilson wrote: > This proves to be very useful when investigating why code suddenly > started failing. > = > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_display.c | 33 +++++++++++++++++++++++++---= ----- > 1 file changed, 25 insertions(+), 8 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 211a097..50d6580 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8293,19 +8293,30 @@ int intel_framebuffer_init(struct drm_device *dev, > { > int ret; > = > - if (obj->tiling_mode =3D=3D I915_TILING_Y) > + if (obj->tiling_mode =3D=3D I915_TILING_Y) { > + DRM_DEBUG("hardware does not support tiling Y\n"); Shouldn't all of these be DRM_DEBUG_KMS()? -- = Ville Syrj=E4l=E4 Intel OTC