From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Add DEBUG messages to all
 intel_create_user_framebuffer error paths
Date: Wed, 19 Dec 2012 13:58:52 +0200
Message-ID: <20121219115852.GU29018@intel.com>
References: <1355868794-3708-1-git-send-email-chris@chris-wilson.co.uk>
	<1355868794-3708-3-git-send-email-chris@chris-wilson.co.uk>
	<20121219114741.GS29018@intel.com>
	<b94cdc$7s48qe@fmsmga001.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7D58BE6474
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 19 Dec 2012 03:58:56 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <b94cdc$7s48qe@fmsmga001.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Dec 19, 2012 at 11:52:11AM +0000, Chris Wilson wrote:
> On Wed, 19 Dec 2012 13:47:41 +0200, Ville Syrj=E4l=E4 <ville.syrjala@linu=
x.intel.com> wrote:
> > On Tue, Dec 18, 2012 at 10:13:14PM +0000, Chris Wilson wrote:
> > > This proves to be very useful when investigating why code suddenly
> > > started failing.
> > > =

> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > >  drivers/gpu/drm/i915/intel_display.c |   33 ++++++++++++++++++++++++=
+--------
> > >  1 file changed, 25 insertions(+), 8 deletions(-)
> > > =

> > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i=
915/intel_display.c
> > > index 211a097..50d6580 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -8293,19 +8293,30 @@ int intel_framebuffer_init(struct drm_device =
*dev,
> > >  {
> > >  	int ret;
> > >  =

> > > -	if (obj->tiling_mode =3D=3D I915_TILING_Y)
> > > +	if (obj->tiling_mode =3D=3D I915_TILING_Y) {
> > > +		DRM_DEBUG("hardware does not support tiling Y\n");
> > =

> > Shouldn't all of these be DRM_DEBUG_KMS()?
> =

> I choose DRM_DEBUG because these are user errors, which I think has been
> the prevailing choice in the past.

drm_crtc.c uses DRM_DEBUG_KMS for user errors too.

-- =

Ville Syrj=E4l=E4
Intel OTC