From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915; Only increment the user-pin-count after successfully pinning the bo Date: Sun, 6 Jan 2013 18:27:59 +0100 Message-ID: <20130106172759.GN5737@phenom.ffwll.local> References: <1357122682-25314-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTP id E5F36E5BFD for ; Sun, 6 Jan 2013 09:26:04 -0800 (PST) Received: by mail-wg0-f52.google.com with SMTP id 12so8728680wgh.31 for ; Sun, 06 Jan 2013 09:26:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <1357122682-25314-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 02, 2013 at 10:31:22AM +0000, Chris Wilson wrote: > As along the error path we do not correct the user pin-count for the > failure, we may end up with userspace believing that it has a pinned > object at offset 0 (when interrupted by a signal for example). > > Signed-off-by: Chris Wilson > Cc: stable@vger.kernel.org pin_vs_interrupt in i-g-t? In any case, applied to -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch