From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Treat crtc->mode.clock == 0 as
	disabled
Date: Mon, 7 Jan 2013 17:40:35 +0100
Message-ID: <20130107164035.GT5737@phenom.ffwll.local>
References: <CAKMK7uH2L=tPUszeO7XMHJjXiJ5ZcG+wVi5u5c2UeQa8-xM=YQ@mail.gmail.com>
	<1357553501-8783-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
	by gabe.freedesktop.org (Postfix) with ESMTP id D2715E62B2
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  7 Jan 2013 08:38:39 -0800 (PST)
Received: by mail-wg0-f44.google.com with SMTP id dr12so9937493wgb.35
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 07 Jan 2013 08:38:39 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1357553501-8783-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Alexey Zaytsev <alexey.zaytsev@gmail.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jan 07, 2013 at 10:11:40AM +0000, Chris Wilson wrote:
> Prevent a divide-by-zero by consistently treating an 'active' CRTC
> without a mode set as actually disabled.
> 
> This looks to have been first introduced with
> 
> commit 24929352481f085c5f85d4d4cbc919ddf106d381
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Mon Jul 2 20:28:59 2012 +0200
> 
>     drm/i915: read out the modeset hw state at load and resume time
> 
> but then combined with
> 
> commit b0a2658acb5bf9ca86b4aab011b7106de3af0add
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Tue Dec 18 09:37:54 2012 +0100
> 
>     drm/i915: don't disable disconnected outputs
> 
> it finally started oopsing.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reported-and-tested-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: stable@vger.kernel.org

Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch