From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Reject out-of-bound sprites Date: Tue, 8 Jan 2013 17:56:43 +0100 Message-ID: <20130108165643.GC5737@phenom.ffwll.local> References: <1355869108-4917-1-git-send-email-chris@chris-wilson.co.uk> <20130108111138.GY5737@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id F3AC8E69D4 for ; Tue, 8 Jan 2013 08:54:46 -0800 (PST) Received: by mail-wg0-f41.google.com with SMTP id ds1so670389wgb.0 for ; Tue, 08 Jan 2013 08:54:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130108111138.GY5737@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 08, 2013 at 12:11:38PM +0100, Daniel Vetter wrote: > On Tue, Dec 18, 2012 at 10:18:28PM +0000, Chris Wilson wrote: > > We make no attempt to fixup the source as we adjust the destination > > rectangle, expect the caller to have already fixed that up. This makes > > no sense, asking userspace to compensate for the kernel adjusting the > > one rectangle not the other, so simply reject any attempt to show an > > partially visible box. Userspace should know better. > > > > Signed-off-by: Chris Wilson > > I guess this makes sense for now, given that the only user we have (ddx) > needs to copy things around anyway ... Still, some common users and > testcases across drivers would be nice for this . > > Applied to fixes. Dropped again, since Ville has a more complete solution to this in his queue. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch