From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 10/10] drm/i915: remove "unclaimed register"
 checks from I915_WRITE
Date: Fri, 18 Jan 2013 12:49:13 -0800
Message-ID: <20130118204913.GA21692@lundgren.amr.corp.intel.com>
References: <1358540953-3979-1-git-send-email-przanoni@gmail.com>
	<1358540953-3979-11-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 755F2E5E9F
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 18 Jan 2013 12:48:02 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1358540953-3979-11-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 18, 2013 at 06:29:12PM -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Some developers don't really like this code polluting I915_WRITE, and
> we've never really measured its negative impacts. So now that we
> properly print ERR_INT interrupts, let's remove the I915_WRITE code
> and promote the interrupt error message to DRM_ERROR.
> 
> The downside of this change is that we lose the ability to check the
> register and print nice backtraces, but at this point most of the
> errors have already been fixed and we're investigating the few
> remaining cases.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I'm really sad to see this go. Especially since our time between new
platform bring-up is decreasing so much. If I were to guess right, every
developer working on a new platform would want this. So while HSW may be
in the clear, HSW+1 suffers.

Could I request that you measure the negative impacts?