From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 29/33] drm/i915: VGA registers need an
 offset on VLV
Date: Fri, 25 Jan 2013 17:18:58 +0100
Message-ID: <20130125161858.GM23080@phenom.ffwll.local>
References: <1359034198-19678-1-git-send-email-ville.syrjala@linux.intel.com>
	<1359034198-19678-30-git-send-email-ville.syrjala@linux.intel.com>
	<20130124224409.GG23080@phenom.ffwll.local>
	<20130125102754.GP9135@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com
	[209.85.215.176])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4B941E6289
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 25 Jan 2013 08:16:53 -0800 (PST)
Received: by mail-ea0-f176.google.com with SMTP id a13so239417eaa.35
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 25 Jan 2013 08:16:52 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130125102754.GP9135@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 25, 2013 at 12:27:54PM +0200, Ville Syrj=E4l=E4 wrote:
> On Thu, Jan 24, 2013 at 11:44:09PM +0100, Daniel Vetter wrote:
> > On Thu, Jan 24, 2013 at 03:29:54PM +0200, ville.syrjala@linux.intel.com=
 wrote:
> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > =

> > > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Admittedly I haven't checked them closely, but with my proposed patch in
> > he modeset_s-r branch, do we still need to adjust these? I kinda don't
> > want to keep the legacy vga plane registers around ...
> =

> I found two exceptions, well, one really.
> =

> i915_disable_vga() pokes at one sequencer register.

Ok, I think we should then only convert that register and add a comment
about it somewhere. I really hope we can get by without all this legacy
vga stuff here ...

> intel_crt_load_detect() polls the sense bit in ST00, but I don't think
> we should ever go there w/ VLV due to is_hotplug=3D1.

Yeah, load detect is used on gen2/3 for VGA, TV load detect has its own
magic.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch