From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug
Date: Tue, 29 Jan 2013 08:52:36 -0800 [thread overview]
Message-ID: <20130129085236.00001740@unknown> (raw)
In-Reply-To: <20130129085418.GF14766@phenom.ffwll.local>
On Tue, 29 Jan 2013 09:54:18 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote:
> > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote:
> > > /sys/kernel/debug has more or less been the standard location of
> > > debugfs for several years now. Other parts of DRM already use
> > > this location, so we should as well.
> > >
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> >
> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Queued for -next, thanks for the patch. Oh and fixed up a bikeshed
> from checkpatch.pl while applying:
>
> Applying: drm/i915: Error state should print /sys/kernel/debug
> WARNING: line over 80 characters
> #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308:
> + DRM_INFO("capturing error event; look for more information
> in /sys/kernel/debug/dri/%d/i915_error_state\n",
>
> total: 0 errors, 1 warnings, 8 lines checked
>
> Yeah, I've added that OCD thing to my patch apply pipeline, let's see
> how much fun it is ;-)
I've not looked at the final patch yet, but I think breaking up
constant strings is considered bad form, and lines above 80 are
generally favored for grepability.
At least James Bottomley said that in his talk and LPC, and a bunch of
other maintainers seemed to agree. (and I agree)
> -Daniel
> >
> > --
> > Damien
next prev parent reply other threads:[~2013-01-29 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 23:32 [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug Ben Widawsky
2013-01-28 23:32 ` [PATCH 2/2] drm/i915: Adding a warning to FBC description Ben Widawsky
2013-01-29 8:49 ` Daniel Vetter
2013-01-29 16:50 ` Ben Widawsky
2013-01-30 14:18 ` Jani Nikula
2013-01-31 3:13 ` Ben Widawsky
2013-01-31 15:37 ` Daniel Vetter
2013-01-29 0:14 ` [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug Carl Worth
2013-01-29 8:41 ` Damien Lespiau
2013-01-29 8:54 ` Daniel Vetter
2013-01-29 9:22 ` Jani Nikula
2013-01-29 16:52 ` Ben Widawsky [this message]
2013-01-29 17:05 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129085236.00001740@unknown \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).