From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt
 code
Date: Tue, 29 Jan 2013 11:00:22 -0800
Message-ID: <20130129190021.GB692@lundgren.nims.intel.com>
References: <1359160867-780-1-git-send-email-ben@bwidawsk.net>
	<1359160867-780-4-git-send-email-ben@bwidawsk.net>
	<20130129125546.GN14766@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id E7EEEE5D36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 29 Jan 2013 10:59:09 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130129125546.GN14766@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jan 29, 2013 at 01:55:46PM +0100, Daniel Vetter wrote:
> On Fri, Jan 25, 2013 at 04:41:05PM -0800, Ben Widawsky wrote:
> > This refactor clearly identifies the GEN specific portion of the aliased
> > ppgtt code. Aside from some of the gen specific parts being extracted,
> > it also preps us for an upcoming patch that pulls out the size, which
> > has some nice benefits.
> > 
> > v2: Fix wonky error handling (Chris)
> > 
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Functionally we seem to have this patch already with
> 
> commit e9ccfd7b94f1ca9b46b992a19d2e8c5af70e4c69
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Thu Jan 24 13:49:56 2013 -0800
> 
>     drm/i915: extract hw ppgtt setup/cleanup code
> 
> Yeah, you're allowed to hate me with the heat of a thousand suns now ;-)
> -Daniel

I already did. I guess when I rebased the series, you hadn't merged
those yet.

-- 
Ben Widawsky, Intel Open Source Technology Center