From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: Adding a warning to FBC
 description
Date: Wed, 30 Jan 2013 19:13:58 -0800
Message-ID: <20130131031356.GA1433@lundgren.kumite>
References: <1359415936-2732-1-git-send-email-ben@bwidawsk.net>
	<1359415936-2732-2-git-send-email-ben@bwidawsk.net>
	<20130129084913.GE14766@phenom.ffwll.local>
	<20130129085039.00001e00@unknown> <87txpyeou8.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id E5CBCE62AA
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 30 Jan 2013 19:12:45 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <87txpyeou8.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jan 30, 2013 at 04:18:39PM +0200, Jani Nikula wrote:
> On Tue, 29 Jan 2013, Ben Widawsky <ben@bwidawsk.net> wrote:
> > On Tue, 29 Jan 2013 09:49:13 +0100
> > Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> >> On Mon, Jan 28, 2013 at 03:32:16PM -0800, Ben Widawsky wrote:
> >> > It should only be used with caution...
> >> > 
> >> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> >> 
> >> Isn't that like the general assumption of these module parameters that
> >> they can have pretty massive bad side-effects? Meaning I'm routinely
> >> checking these already anyway in bug reports, same for non-standard
> >> rc6 settings.
> >> -Daniel
> >> 
> >
> > I felt that way too, until we got a complain in #intel-gfx and it
> > changed my mind.
> >
> > Whatevs, I ain't gonna fight for this one, I'll just punt the bug
> > reporter to you next time.
> 
> Yeah, I agree it's *our* general assumption that these may have bad
> side-effects. People just see the random forum posts recommending this
> and that module param, and stick them in... Hmm, which means they won't
> read that warning anyway. DRM_INFO("don't report a bug about this") when
> enabling a feature that's disabled by default on a platform?
> 
> Jani.

Now that's the kind of pessimism I like to hear! OTOH, the current
message: "Enable frame buffer compression for power savings" wouldn't
indicate any reason to not use it. And yes, I know, what git blame says.
I was on a personal crusade to fix FBC on ILK when I wrote that.

I like DRM_INFO as well, but I don't really see a reason not to change
the modinfo (DRM_INFO requires loading the wrong setting first).

-- 
Ben Widawsky, Intel Open Source Technology Center