From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/1] tests/gem_ctx_exec: fix destroy ioctl number Date: Mon, 4 Feb 2013 17:27:25 +0100 Message-ID: <20130204162725.GG5843@phenom.ffwll.local> References: <1359983610-10621-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 25F33E62C2 for ; Mon, 4 Feb 2013 08:25:13 -0800 (PST) Received: by mail-wi0-f181.google.com with SMTP id hm6so1856492wib.2 for ; Mon, 04 Feb 2013 08:25:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1359983610-10621-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Feb 04, 2013 at 03:13:30PM +0200, Mika Kuoppala wrote: > Destroy was never called properly > > Signed-off-by: Mika Kuoppala Oops, that's a bit a goof-up, nice catch. While at it, can you please augment the test to check whether a destroyed context doesn't work any more for batchbuffers? It looks like gem_ctx_exec.c should be easy to extend with this. -Daniel > --- > tests/gem_ctx_exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c > index 423f1ee..0288fe8 100644 > --- a/tests/gem_ctx_exec.c > +++ b/tests/gem_ctx_exec.c > @@ -57,7 +57,7 @@ struct local_drm_i915_gem_context_destroy { > }; > > #define CONTEXT_CREATE_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2d, struct local_drm_i915_gem_context_create) > -#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x23, struct local_drm_i915_gem_context_destroy) > +#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2e, struct local_drm_i915_gem_context_destroy) > > static uint32_t context_create(int fd) > { > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch