From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Fix sprite_scaling_enabled for multiple sprites Date: Fri, 8 Feb 2013 21:26:30 +0000 Message-ID: <20130208212630.GA519@cantiga.alporthouse.com> References: <1360358015-26643-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B995E5EBD for ; Fri, 8 Feb 2013 13:26:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1360358015-26643-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 08, 2013 at 11:13:35PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > We have more than one sprite, so a boolean simply won't cut it. > Turn sprite_scaling_enabled into a bitmask and track the state > of sprite scaler for each sprite independently. > = > Also don't re-enable LP watermarks until the sprite registers > have actually been written, and thus sprite scaling has really > been disabled. I would emphasize this, since this fix is worthy of Cc: stable@ = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Chris Wilson -Chris -- = Chris Wilson, Intel Open Source Technology Centre