From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: detect wrong MCH watermark values
Date: Sat, 9 Feb 2013 12:24:02 -0800
Message-ID: <20130209202401.GA8121@lundgren.kumite>
References: <20130207180907.GA723@lundgren.nims.intel.com>
	<1360440222-21830-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id C4ECAE5C2B
	for <intel-gfx@lists.freedesktop.org>;
	Sat,  9 Feb 2013 12:22:35 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1360440222-21830-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, "Runyan,
	Arthur J" <arthur.j.runyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Feb 09, 2013 at 09:03:42PM +0100, Daniel Vetter wrote:
> Some early bios versions seem to ship with the wrong tuning values for
> the MCH, possible resulting in pipe underruns under load. Especially
> on DP outputs this can lead to black screen, since DP really doesn't
> like an occasional whack from an underrun.
> 
> Unfortunately the registers seem to be locked after boot, so the only
> thing we can do is politely point out issues and suggest a BIOS
> upgrade.
> 
> Arthur Runyan pointed us at this issue while discussion DP bugs - thus
> far no confirmation from a bug report yet that it helps. But at least
> some of my machines here have wrong values, so this might be useful in
> understanding bug reports.
> 
> v2: After a bit more discussion with Art and Ben we've decided to only
> the check the watermark values, since the OREF ones could be be a
> notch more aggressive on certain machines.
> 
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Cc: Runyan, Arthur J <arthur.j.runyan@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I wouldn't mind if you printed the OREF values, even if you didn't use
them to detect.

But,
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

[snip]

-- 
Ben Widawsky, Intel Open Source Technology Center