From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix gen2 mappable calculations Date: Sun, 10 Feb 2013 00:03:01 +0100 Message-ID: <20130209230301.GZ5813@phenom.ffwll.local> References: <1360351967-1011-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170]) by gabe.freedesktop.org (Postfix) with ESMTP id A4391E5D52 for ; Sat, 9 Feb 2013 15:00:46 -0800 (PST) Received: by mail-ea0-f170.google.com with SMTP id a11so2123840eaa.15 for ; Sat, 09 Feb 2013 15:00:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1360351967-1011-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 08, 2013 at 11:32:47AM -0800, Ben Widawsky wrote: > When I refactored the code initially, I forgot that gen2 uses a > different bar for the CPU mappable aperture. The agp-less code knows > nothing of generations less than 5, so we have to expand the gtt_probe > function to include the mappable base and end. > > It was originally broken by me: > commit baa09f5fd8a6d033ec075355dda99a65b7f6a0f3 > Author: Ben Widawsky > Date: Thu Jan 24 13:49:57 2013 -0800 > > drm/i915: Add probe and remove to the gtt ops > > Reported-by: Chris Wilson > Signed-off-by: Ben Widawsky Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch