From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v3] drm/i915: Extract ring init from hw_init
Date: Sun, 10 Feb 2013 00:07:04 +0100
Message-ID: <20130209230704.GA5813@phenom.ffwll.local>
References: <1360347470-14000-1-git-send-email-ben@bwidawsk.net>
	<1360352964-8169-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com
	[209.85.215.179])
	by gabe.freedesktop.org (Postfix) with ESMTP id 565CEE5C5F
	for <intel-gfx@lists.freedesktop.org>;
	Sat,  9 Feb 2013 15:04:49 -0800 (PST)
Received: by mail-ea0-f179.google.com with SMTP id d12so2104593eaa.24
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 09 Feb 2013 15:04:48 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1360352964-8169-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Feb 08, 2013 at 11:49:24AM -0800, Ben Widawsky wrote:
> The ring initialization will differ a bit in upcoming generations, and
> this split will prepare the code for what's needed.
> 
> This patch also fixes a bug introduced in:
> commit 99433931950f33039d9e1a52b4ed9af3f1b58e84
> Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Date:   Tue Jan 22 14:12:17 2013 +0200
> 
>     drm/i915: use gem_set_seqno() on hardware init
> 
> After doing the extraction, the bad error handling became obvious.  I
> acknowledge that this should be two patches, but it's a pretty
> small/trivial patch. If requested, I can certainly do the fix as a
> distinct patch.
> 
> v2: Should be cleanup blt, not init blt on failure (Chris)
> 
> v3: Forgot to git add on v2
> 
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch