From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 2/6] drm/i915: Don't wait for page flips if there was GPU reset Date: Wed, 13 Feb 2013 10:23:28 +0000 Message-ID: <20130213102328.GB20865@dyon.amr.corp.intel.com> References: <1359476018-31274-1-git-send-email-ville.syrjala@linux.intel.com> <1359476018-31274-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 89806E65D2 for ; Wed, 13 Feb 2013 02:23:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <1359476018-31274-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 29, 2013 at 06:13:34PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > If a GPU reset occurs while a page flip has been submitted to the ring, > the flip will never complete once the ring has been reset. > = > The GPU reset can be detected by sampling the reset_counter before the > flip is submitted, and then while waiting for the flip, the sampled > counter is compared with the current reset_counter value. > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Damien Lespiau You might want to rename reset_counter to flip_reset_counter to indicate this field is specific to the flipping code. Other parts of the code might need something similar as well? -- = Damien