From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/i915: Preserve the FDI line reversal override bit on CPT Date: Thu, 14 Feb 2013 21:03:28 +0100 Message-ID: <20130214200328.GV5813@phenom.ffwll.local> References: <1355251711-2169-1-git-send-email-damien.lespiau@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FCE7E5DF4 for ; Thu, 14 Feb 2013 12:01:13 -0800 (PST) Received: by mail-ee0-f44.google.com with SMTP id l10so1488145eei.31 for ; Thu, 14 Feb 2013 12:01:13 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, Feb 14, 2013 at 05:51:24PM -0200, Paulo Zanoni wrote: > Hi > = > 2012/12/18 Rodrigo Vivi : > > On Tue, Dec 11, 2012 at 4:48 PM, Damien Lespiau > > wrote: > >> FDI_RX_PLL_ENABLE > > I noticed that we have a restriction on PLL_ENABLE: > > "After enabling the FDI PLL, software must wait for a warmup period > > before enabling the link" > > > > warmup for this is 25us. > > Are we covered already with this 220 or should we increase it? > > I'm not sure. > = > Yes. On the Haswell doc, mode set sequence for CRT: "Enable PCH FDI > Receiver PLL, wait 200 =B5s for warmup plus 20 =B5s DMI latency". > = > Reviewed-by: Paulo Zanoni Picked up the first patch of this series. Or does that r-b also how for the DDI patch in here? The 3rd one likely doesn't apply any more, and I don't really have an opinion about that particular bikeshed. -Daniel > = > > > > Other than that, feel free to use > > Reviewed-by: Rodrigo Vivi > > > > > > > > > > > > -- > > Rodrigo Vivi > > Blog: http://blog.vivi.eng.br > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Paulo Zanoni > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch