From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: add \n to the end of sysfs
 attributes
Date: Tue, 19 Feb 2013 12:19:41 +0100
Message-ID: <20130219111941.GU5813@phenom.ffwll.local>
References: <1360831331-30040-1-git-send-email-jani.nikula@intel.com>
	<20130214174635.GA20674@bwidawsk.net> <87ppzwpp91.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f176.google.com (mail-we0-f176.google.com
	[74.125.82.176])
	by gabe.freedesktop.org (Postfix) with ESMTP id D66EEE6489
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 19 Feb 2013 03:17:23 -0800 (PST)
Received: by mail-we0-f176.google.com with SMTP id s43so5654914wey.35
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 19 Feb 2013 03:17:22 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <87ppzwpp91.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@intel.com>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Feb 19, 2013 at 12:33:14PM +0200, Jani Nikula wrote:
> On Thu, 14 Feb 2013, Ben Widawsky <ben@bwidawsk.net> wrote:
> > On Thu, Feb 14, 2013 at 10:42:11AM +0200, Jani Nikula wrote:
> >> It is customary to end sysfs attributes with a newline.
> >> 
> >
> > As best I can tell, you are correct. Have you tested powertop with this
> > change? If not, can you?
> 
> Good point. Tested, and eyeballed the powertop sysfs reading code. This
> should be all right.

Patche queued for next, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch