From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/6] drm/i915: don't restore LVDS enable state blindly v2 Date: Tue, 19 Feb 2013 22:35:35 +0100 Message-ID: <20130219213535.GB5813@phenom.ffwll.local> References: <1361304703-2869-1-git-send-email-jbarnes@virtuousgeek.org> <1361304703-2869-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id D3C75E668D for ; Tue, 19 Feb 2013 13:33:16 -0800 (PST) Received: by mail-ee0-f54.google.com with SMTP id c41so3842805eek.41 for ; Tue, 19 Feb 2013 13:33:16 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Feb 19, 2013 at 05:39:49PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/19 Jesse Barnes : > > We still rely on a few LVDS bits, but restoring the enable bit can cause > > trouble at this point, so don't. > > > > v2: use the right mask to prevent restore (Daniel) > > conditionalize on KMS support (Denial) > > > > Signed-off-by: Jesse Barnes > Reviewed-by: Paulo Zanoni > > Briefly tested on SNB, and it still works. Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch