From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 2/2] drm/i915: Fix races in gen4 page
 flip interrupt handling
Date: Wed, 20 Feb 2013 15:38:08 +0100
Message-ID: <20130220143808.GE5813@phenom.ffwll.local>
References: <1361279799-16582-1-git-send-email-ville.syrjala@linux.intel.com>
	<1361279799-16582-3-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
	[209.85.212.173])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7D3E0E673E
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 20 Feb 2013 06:35:50 -0800 (PST)
Received: by mail-wi0-f173.google.com with SMTP id hq4so6258179wib.6
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 20 Feb 2013 06:35:49 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1361279799-16582-3-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Feb 19, 2013 at 03:16:39PM +0200, ville.syrjala@linux.intel.com wro=
te:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Use the gen3 logic for handling page flip interrupts on gen4.
> =

> Unfortuantely this kills the stall_check since that looks like it can
> easily trigger too early. With the current logic the stall check would
> kick in on the first vblank after the flip has been submitted to the
> ring. If the CS takes longer than that to process the commands in the
> ring, the stall check will cause the page flip to be complete too
> early. That doesn't sound like a very good idea. Something better
> should be deviced if we still need the stall check. For now, mark
> i915_pageflip_stall_check() as unused.
> =

> v2: Fix irq enable_mask and add __always_unused (Chris Wilson)
> =

> References: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-=
intel/+bug/1116587
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Both merge to dinq, thanks.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch