From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Refactor gen2 to gen4 vblank interrupt handling Date: Wed, 20 Feb 2013 20:21:25 +0100 Message-ID: <20130220192125.GF5813@phenom.ffwll.local> References: <1361308604-32553-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A7B99E5F8D for ; Wed, 20 Feb 2013 11:19:06 -0800 (PST) Received: by mail-ee0-f54.google.com with SMTP id c41so4470058eek.13 for ; Wed, 20 Feb 2013 11:19:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <1361308604-32553-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Feb 19, 2013 at 11:16:44PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > The indentation is getting way too deep. Pull the vblank interupt > handling out to separate functions. > = > v2: Keep flip_mask handling in the main irq handler and > flatten {i8xx,i915}_handle_vblank() even further. > = > Signed-off-by: Ville Syrj=E4l=E4 I like this too much to stall on testing feedback for the original two patches. Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch