From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 09/13] drm/i915: add reset_state for hw_contexts Date: Wed, 27 Feb 2013 09:20:49 -0800 Message-ID: <20130227092049.1735257d@jbarnes-desktop> References: <1361876716-8625-1-git-send-email-mika.kuoppala@intel.com> <1361876716-8625-10-git-send-email-mika.kuoppala@intel.com> <512D65A0.2040305@freedesktop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 77339E661C for ; Wed, 27 Feb 2013 09:21:41 -0800 (PST) In-Reply-To: <512D65A0.2040305@freedesktop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ian Romanick Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 26 Feb 2013 17:47:12 -0800 Ian Romanick wrote: > On 02/26/2013 03:05 AM, Mika Kuoppala wrote: > > For arb-robustness, every context needs to have it's own > > reset state tracking. Default context will be handled in a identical > > way as the no-context case in further down in the patch set. > > For no-context case, the reset state will be stored in > > the file_priv part. > > > > v2: handle default context inside get_reset_state > > This isn't the interface we want. I already sent you the patches for > Mesa, and you seem to have completely ignored them. Moreover, this > interface provides no mechanism to query for its existence (other than > relying on the kernel version), and no method to deprecate it. Before you get all wound up about this, note that you're replying to a kernel internal function, not the ioctl that will be exposed to Mesa... -- Jesse Barnes, Intel Open Source Technology Center