From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 16/28] drm/i915: add Punit read/write
 routines for VLV
Date: Mon, 4 Mar 2013 08:35:11 -0800
Message-ID: <20130304083511.3803be5d@jbarnes-desktop>
References: <1362172471-7643-1-git-send-email-jbarnes@virtuousgeek.org>
	<1362172471-7643-17-git-send-email-jbarnes@virtuousgeek.org>
	<876217wo6g.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy13-pub.unifiedlayer.com (oproxy13-pub.unifiedlayer.com
	[69.89.16.30])
	by gabe.freedesktop.org (Postfix) with SMTP id AEF80E60DC
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  4 Mar 2013 08:34:55 -0800 (PST)
In-Reply-To: <876217wo6g.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 04 Mar 2013 10:43:03 +0200
Jani Nikula <jani.nikula@linux.intel.com> wrote:

> > +int valleyview_punit_read(struct drm_i915_private *dev_priv, u8 addr, u32 *val)
> > +{
> > +	u32 cmd, devfn, opcode, port, be, bar;
> > +
> > +	bar = 0;
> > +	be = 0xf;
> > +	port = IOSF_PORT_PUNIT;
> > +	opcode = PUNIT_OPCODE_REG_READ;
> > +	devfn = 16;
> > +
> > +	cmd = (devfn << IOSF_DEVFN_SHIFT) | (opcode << IOSF_OPCODE_SHIFT) |
> > +		(port << IOSF_PORT_SHIFT) | (be | IOSF_BYTE_ENABLES_SHIFT) |  
> 
> Should be << not | for IOSF_BYTE_ENABLES_SHIFT. Ditto in the write
> function below.
> 
> How about picking up a fixed and reworked version of this patch from the
> series I sent you? ;)

Yeah I suck.  I'll respin with your bits.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center