From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/6] drm/i915: remove disabled memset of framebuffer from intel_fb Date: Mon, 4 Mar 2013 23:04:33 +0100 Message-ID: <20130304220433.GB9021@phenom.ffwll.local> References: <1361304703-2869-1-git-send-email-jbarnes@virtuousgeek.org> <1361304703-2869-7-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) by gabe.freedesktop.org (Postfix) with ESMTP id B51CAE5DCD for ; Mon, 4 Mar 2013 14:02:04 -0800 (PST) Received: by mail-ea0-f173.google.com with SMTP id i1so987922eaa.32 for ; Mon, 04 Mar 2013 14:02:03 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Feb 19, 2013 at 06:17:09PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/19 Jesse Barnes : > > Commented out and unneeded. > > Oh, "DRM: i915: add mode setting support" added it, already commented. > > > > > Signed-off-by: Jesse Barnes > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. I'll hold off on the other ones until it's clear what's going on on Paulo's machine. -Daniel > > > --- > > drivers/gpu/drm/i915/intel_fb.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c > > index 987bc33..f4e0b88 100644 > > --- a/drivers/gpu/drm/i915/intel_fb.c > > +++ b/drivers/gpu/drm/i915/intel_fb.c > > @@ -152,8 +152,6 @@ static int intelfb_create(struct intel_fbdev *ifbdev, > > /* This driver doesn't need a VT switch to restore the mode on resume */ > > info->skip_vt_switch = true; > > > > -// memset(info->screen_base, 0, size); > > - > > drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); > > drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); > > > > -- > > 1.7.9.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Paulo Zanoni > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch