From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 8/8] drm/i915: clarify confusion between
 SDVO and HDMI registers
Date: Mon, 4 Mar 2013 23:28:09 +0100
Message-ID: <20130304222809.GC9021@phenom.ffwll.local>
References: <1361224828-3730-1-git-send-email-przanoni@gmail.com>
	<1361224828-3730-9-git-send-email-przanoni@gmail.com>
	<20130219120645.GX5813@phenom.ffwll.local>
	<CA+gsUGTNvUynUpAeAtQuny-8ox1rO_U8qVv=dQr0dyC+YAML9w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com [74.125.83.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id E1A69E6866
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  4 Mar 2013 14:25:37 -0800 (PST)
Received: by mail-ee0-f48.google.com with SMTP id t10so4178036eei.7
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 04 Mar 2013 14:25:37 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGTNvUynUpAeAtQuny-8ox1rO_U8qVv=dQr0dyC+YAML9w@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Feb 19, 2013 at 04:19:52PM -0300, Paulo Zanoni wrote:
> Hi
> 
> 2013/2/19 Daniel Vetter <daniel@ffwll.ch>:
> > On Mon, Feb 18, 2013 at 07:00:27PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> Some HDMI registers can be used for SDVO, so saying "HDMIB" should be
> >> the same as saying "SDVOB" for a given HW generation. This was not
> >> true and led to confusions and even a regression.
> >>
> >> Previously we had:
> >>   - SDVO{B,C} defined as the Gen3+ registers
> >>   - HDMI{B,C,D} and PCH_SDVOB defined as the PCH registers
> >>
> >> But now:
> >>   - SDVO{B,C} became GEN3_SDVO{B,C} on SDVO code
> >>   - SDVO{B,C} became GEN4_HDMI{B,C} on HDMI code
> >>   - HDMI{B,C,D} became PCH_HDMI{B,C,D}
> >>   - PCH_SDVOB is still the same thing
> >>
> >> v2: Rebase (v1 was sent in May 2012).
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > I think we still have a bit of ugly left in here, especially that the
> > register bit definitions are splattered all over irks me a bit. What about
> > moving the HDMI stuff up to the SDVO definitions and giving the HDMI bits
> > consisten HDMI_ prefixes? Imo there's no point in adding duplicate
> > #defines for all the SDVO_ bits we use in intel_hdmi.c ...
> 
> I agree, there's more to clean up. I thought about amending your
> suggestions to this patch, but I don't think this will be a good idea,
> so I will send 3 additional patches on top of this one. Feel free to
> merge them as a single patch if you want.

I've merged all four patches to dinq, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch