From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: enable irqs earlier when resuming Date: Tue, 5 Mar 2013 08:53:48 +0000 Message-ID: <20130305085326.GA27641@cantiga.alporthouse.com> References: <1362473458-9648-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1362473458-9648-1-git-send-email-daniel.vetter@ffwll.ch> Sender: stable-owner@vger.kernel.org To: Daniel Vetter Cc: Intel Graphics Development , "for 3.8 only" , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 05, 2013 at 09:50:58AM +0100, Daniel Vetter wrote: > We need it to restore the ilk rc6 context, since the gpu wait no > requires interrupts. But in general having interrupts around should > help in code sanity, since more and more stuff is interrupt driven. > > This regression has been introduced in > > commit 3e9605018ab3e333d51cc90fccfde2031886763b > Author: Chris Wilson > Date: Tue Nov 27 16:22:54 2012 +0000 > > drm/i915: Rearrange code to only have a single method for waiting upon the ring Not entirely, as we can also regard this as an oversight from fixing up the irq sequence during initialisation... :-p > > Like in the driver load code we need to make sure that hotplug > interrupts don't cause havoc with our modeset state, hence block them > with the existing infrastructure. Again we ignore races where we might > loose hotplug interrupts ... > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=54691 > Cc: stable@vger.kernel.org (for 3.8 only) > Cc: Chris Wilson > Cc: Mika Kuoppala > Reported-and-Tested-by: Ilya Tumaykin > Signed-off-by: Daniel Vetter Reviewed-by: Chris wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre