From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 23/28] drm/i915: use VLV DIP routines on VLV
Date: Wed, 6 Mar 2013 11:09:21 -0800
Message-ID: <20130306110921.74343a07@jbarnes-desktop>
References: <1362172471-7643-1-git-send-email-jbarnes@virtuousgeek.org>
	<1362172471-7643-24-git-send-email-jbarnes@virtuousgeek.org>
	<20130306190037.GU9021@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6])
	by gabe.freedesktop.org (Postfix) with SMTP id 93D1BE68AF
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  6 Mar 2013 11:09:11 -0800 (PST)
In-Reply-To: <20130306190037.GU9021@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 6 Mar 2013 20:00:37 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Fri, Mar 01, 2013 at 01:14:26PM -0800, Jesse Barnes wrote:
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> >  drivers/gpu/drm/i915/intel_hdmi.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index fcb36c6..9982b7f 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -1038,7 +1038,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
> >  		BUG();
> >  	}
> >  
> > -	if (!HAS_PCH_SPLIT(dev)) {
> > +	if (!HAS_PCH_SPLIT(dev) && !IS_VALLEYVIEW(dev)) {
> 
> We have an IS_VLV block right below ... move it up? Or just rework the if
> ladder here to not use negation, that's imo easier to parse, too.
> -Daniel
> 
> >  		intel_hdmi->write_infoframe = g4x_write_infoframe;
> >  		intel_hdmi->set_infoframes = g4x_set_infoframes;
> >  	} else if (IS_VALLEYVIEW(dev)) {
> > -- 

Yeah that would be better.

-- 
Jesse Barnes, Intel Open Source Technology Center