From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 28/28] drm/i915/dp: add pre-PCH eDP checking
 to DP detect for VLV
Date: Wed, 6 Mar 2013 12:55:23 -0800
Message-ID: <20130306125523.599e02b4@jbarnes-desktop>
References: <1362172471-7643-1-git-send-email-jbarnes@virtuousgeek.org>
	<1362172471-7643-29-git-send-email-jbarnes@virtuousgeek.org>
	<20130306190559.GX9021@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy13-pub.unifiedlayer.com (oproxy13-pub.unifiedlayer.com
	[69.89.16.30])
	by gabe.freedesktop.org (Postfix) with SMTP id 68335E5DAF
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  6 Mar 2013 12:55:01 -0800 (PST)
In-Reply-To: <20130306190559.GX9021@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 6 Mar 2013 20:05:59 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Fri, Mar 01, 2013 at 01:14:31PM -0800, Jesse Barnes wrote:
> > Allows us to detect eDP panels that may not have the hotplug pin wired up.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Historically the lid status is horribly broken which is why it's disabled
> by default. What changed to now enable it unconditionally? Is this a
> requirement on vlv?
> -Daniel
> 
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 05e1000..c127cb7 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -2413,6 +2413,16 @@ g4x_dp_detect(struct intel_dp *intel_dp)
> >  	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
> >  	uint32_t bit;
> >  
> > +	/* Can't disconnect eDP, but you can close the lid... */
> > +	if (is_edp(intel_dp)) {
> > +		enum drm_connector_status status;
> > +
> > +		status = intel_panel_detect(dev);
> > +		if (status == connector_status_unknown)
> > +			status = connector_status_connected;
> > +		return status;
> > +	}
> > +

Well this doesn't touch the panel_detect() stuff at all, where we have
the hacks to avoid using _LID...

-- 
Jesse Barnes, Intel Open Source Technology Center