From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 24/28] drm/i915: export intel_dpio_write for use in intel_dp.c Date: Wed, 6 Mar 2013 20:02:43 +0100 Message-ID: <20130306190243.GV9021@phenom.ffwll.local> References: <1362172471-7643-1-git-send-email-jbarnes@virtuousgeek.org> <1362172471-7643-25-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by gabe.freedesktop.org (Postfix) with ESMTP id C573FE5C5D for ; Wed, 6 Mar 2013 11:00:11 -0800 (PST) Received: by mail-we0-f173.google.com with SMTP id x51so456566wey.32 for ; Wed, 06 Mar 2013 11:00:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <1362172471-7643-25-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 01, 2013 at 01:14:27PM -0800, Jesse Barnes wrote: > We need it for some DP training related bits. > > Signed-off-by: Jesse Barnes Maintainer-bikeshed: Imo having such unstatic-only patches doesn't really add value, I prefer it squashed with the new use-site (with a small comment in the commit message maybe). True bikeshed, so will merge anyway. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 3 +-- > drivers/gpu/drm/i915/intel_drv.h | 2 ++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 2559435..022349b 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -434,8 +434,7 @@ u32 intel_dpio_read(struct drm_i915_private *dev_priv, int reg) > return I915_READ(DPIO_DATA); > } > > -static void intel_dpio_write(struct drm_i915_private *dev_priv, int reg, > - u32 val) > +void intel_dpio_write(struct drm_i915_private *dev_priv, int reg, u32 val) > { > WARN_ON(!mutex_is_locked(&dev_priv->dpio_lock)); > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 494037d..03fdfbd 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -661,6 +661,8 @@ extern int intel_sprite_get_colorkey(struct drm_device *dev, void *data, > struct drm_file *file_priv); > > extern u32 intel_dpio_read(struct drm_i915_private *dev_priv, int reg); > +extern void intel_dpio_write(struct drm_i915_private *dev_priv, int reg, > + u32 val); > > /* Power-related functions, located in intel_pm.c */ > extern void intel_init_pm(struct drm_device *dev); > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch