From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 28/28] drm/i915/dp: add pre-PCH eDP checking to DP detect for VLV Date: Wed, 6 Mar 2013 20:05:59 +0100 Message-ID: <20130306190559.GX9021@phenom.ffwll.local> References: <1362172471-7643-1-git-send-email-jbarnes@virtuousgeek.org> <1362172471-7643-29-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 304D6E5C5D for ; Wed, 6 Mar 2013 11:03:27 -0800 (PST) Received: by mail-we0-f178.google.com with SMTP id o45so1154539wer.37 for ; Wed, 06 Mar 2013 11:03:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <1362172471-7643-29-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 01, 2013 at 01:14:31PM -0800, Jesse Barnes wrote: > Allows us to detect eDP panels that may not have the hotplug pin wired up. > > Signed-off-by: Jesse Barnes Historically the lid status is horribly broken which is why it's disabled by default. What changed to now enable it unconditionally? Is this a requirement on vlv? -Daniel > --- > drivers/gpu/drm/i915/intel_dp.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 05e1000..c127cb7 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -2413,6 +2413,16 @@ g4x_dp_detect(struct intel_dp *intel_dp) > struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > uint32_t bit; > > + /* Can't disconnect eDP, but you can close the lid... */ > + if (is_edp(intel_dp)) { > + enum drm_connector_status status; > + > + status = intel_panel_detect(dev); > + if (status == connector_status_unknown) > + status = connector_status_connected; > + return status; > + } > + > switch (intel_dig_port->port) { > case PORT_B: > bit = PORTB_HOTPLUG_LIVE_STATUS; > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch