From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 04/26] drm/i915: update VLV PLL and DPIO code
Date: Fri, 8 Mar 2013 08:52:23 -0800
Message-ID: <20130308085223.3818ad86@jbarnes-desktop>
References: <1362175722-9281-1-git-send-email-jbarnes@virtuousgeek.org>
	<1362175722-9281-4-git-send-email-jbarnes@virtuousgeek.org>
	<87ip52uic3.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id BD086E6E20
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  8 Mar 2013 08:52:11 -0800 (PST)
In-Reply-To: <87ip52uic3.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 08 Mar 2013 15:33:32 +0200
Jani Nikula <jani.nikula@linux.intel.com> wrote:

> > +		intel_dpio_write(dev_priv, 0x8438, 0x00760018);
> > +		intel_dpio_write(dev_priv, 0x845c, 0x00400888);
> > +
> > +		intel_dpio_write(dev_priv, 0x8400, 0x10080);
> > +		intel_dpio_write(dev_priv, 0x8404, 0x00600060);
> > +	}
> > +}  
> 
> Dunno, it feels a bit funny that you add loads of #defines for the dpio
> stuff, and then use magic numbers here.
> 
> Also, some of the regs are per-pipe, which is probably all right given
> the intel_pipe_has_type() checks, but perhaps it would be more
> self-explanatory if the pipe number was used anyway.
> 
> All in all, just a /* XXX: clear these up */ would be good too.

I know, it's ugly.  I'm having to make up names for some of these since
we don't have real docs for them, just cspec info.  Agree that they
could be nicer, but w/o a real programming guide they won't map back to
anything useful anyway, so the numbers may actually be better.

I took your other comments into account already from your last review,
I'll post updated patches today.

-- 
Jesse Barnes, Intel Open Source Technology Center