From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/6] drm/i915: Initialize wait in intel_ddi_prepare_link_retrain() Date: Fri, 8 Mar 2013 13:03:12 -0800 Message-ID: <20130308210312.GC31789@bwidawsk.net> References: <1362670228-19494-1-git-send-email-damien.lespiau@intel.com> <1362670228-19494-2-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 89D99E5C11 for ; Fri, 8 Mar 2013 13:03:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <1362670228-19494-2-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 07, 2013 at 03:30:24PM +0000, Damien Lespiau wrote: > We weren't initializing wait, which could lead to the use of a random > value from the stack in the "if (wait)" condition. > > Signed-off-by: Damien Lespiau Reviewed-by: Ben Widawsky [snip] -- Ben Widawsky, Intel Open Source Technology Center