From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/20] drm/i915: add power context allocation and setup on VLV v2 Date: Tue, 12 Mar 2013 00:01:10 +0000 Message-ID: <20130312000110.GA2129@cantiga.alporthouse.com> References: <1362768363-3710-1-git-send-email-jbarnes@virtuousgeek.org> <1362768363-3710-9-git-send-email-jbarnes@virtuousgeek.org> <20130311234030.GF3872@bremse> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 066E5E5CF8 for ; Mon, 11 Mar 2013 17:01:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130311234030.GF3872@bremse> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 12, 2013 at 12:40:30AM +0100, Daniel Vetter wrote: > On Fri, Mar 08, 2013 at 10:45:52AM -0800, Jesse Barnes wrote: > > The Gunit has a separate reg for this, so allocate some stolen space for > > the power context and initialize the reg. > > Is it a requirement to use stolen space? The reason we're allocating rings > and all from stolen is just to test things a bit better and ensure we have > a decent chance that stolen handling for fastboot works ... Some comment > somewhere would be good to clarify this. I'm in favour of making these small permanent allocations from stolen whereever possible. But you are right to point out that we need to clearly mark anthing that may require physically contiguous memory, just in case. -Chris -- Chris Wilson, Intel Open Source Technology Centre