From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 15/15] drm/i915: add missing space in error message Date: Fri, 15 Mar 2013 14:10:20 -0700 Message-ID: <20130315211019.GO17773@bwidawsk.net> References: <1362611003-4823-1-git-send-email-przanoni@gmail.com> <1362611003-4823-16-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id C0132E5DB3 for ; Fri, 15 Mar 2013 14:10:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1362611003-4823-16-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 06, 2013 at 08:03:22PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > To avoid this: > [ 256.798060] [drm] capturing error event; look for more information > in/sys/kernel/debug/dri/0/i915_error_state > > Signed-off-by: Paulo Zanoni Reviewed-by: Ben Widawsky You may want to add to the commit message that this fixes the issue introduced below: commit 2f86f1916504525a6fdd6b412374b4ebf1102cbe Author: Ben Widawsky Date: Mon Jan 28 15:32:15 2013 -0800 drm/i915: Error state should print /sys/kernel/debug ... [danvet: split up long line.] <----- he did it Signed-off-by: Daniel Vetter I personally still believe we shouldn't chop up strings like this. > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index aefc674..0abd8ec 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1340,7 +1340,7 @@ static void i915_capture_error_state(struct drm_device *dev) > return; > } > > - DRM_INFO("capturing error event; look for more information in" > + DRM_INFO("capturing error event; look for more information in " > "/sys/kernel/debug/dri/%d/i915_error_state\n", > dev->primary->index); > > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center