From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/15] drm/i915: remove DSPPOS register Date: Sun, 17 Mar 2013 21:39:29 +0100 Message-ID: <20130317203929.GO9021@phenom.ffwll.local> References: <1362611003-4823-1-git-send-email-przanoni@gmail.com> <1362611003-4823-9-git-send-email-przanoni@gmail.com> <20130307094314.GT4469@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 53371E5D01 for ; Sun, 17 Mar 2013 13:36:45 -0700 (PDT) Received: by mail-ea0-f181.google.com with SMTP id z10so2188416ead.26 for ; Sun, 17 Mar 2013 13:36:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130307094314.GT4469@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 07, 2013 at 11:43:14AM +0200, Ville Syrj=E4l=E4 wrote: > On Wed, Mar 06, 2013 at 08:03:15PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > = > > I couldn't find any evidence that this register exists on Gen2+. On > > Gen 2/3/4 documents this register is listed as reserved and read-only. > > On the newer Gens this register is not even documented. > = > DSPPOS goes hand in hand with DSPSIZE. IIRC DSPA never had the > windowing capability, but DSPB and DSPC on older gens had it. Indeed Ville's right here, gen2/3 have this on sprite B/C (you could move those things around back then to different pipes ...). So I think we want a gen <=3D 3 check here (gen4+ lost this apparently with the fixed pipe->plane mapping). -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch