From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 15/15] drm/i915: add missing space in error
 message
Date: Sun, 17 Mar 2013 21:57:03 +0100
Message-ID: <20130317205703.GV9021@phenom.ffwll.local>
References: <1362611003-4823-1-git-send-email-przanoni@gmail.com>
	<1362611003-4823-16-git-send-email-przanoni@gmail.com>
	<20130315211019.GO17773@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8AD9DE5C37
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 17 Mar 2013 13:54:18 -0700 (PDT)
Received: by mail-ee0-f42.google.com with SMTP id b47so2283994eek.15
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 17 Mar 2013 13:54:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130315211019.GO17773@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 15, 2013 at 02:10:20PM -0700, Ben Widawsky wrote:
> On Wed, Mar 06, 2013 at 08:03:22PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > To avoid this:
> > [  256.798060] [drm] capturing error event; look for more information
> > in/sys/kernel/debug/dri/0/i915_error_state
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Queued for -next, thanks for the patch.

> You may want to add to the commit message that this fixes the issue introduced below:
> commit 2f86f1916504525a6fdd6b412374b4ebf1102cbe
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Mon Jan 28 15:32:15 2013 -0800
> 
>     drm/i915: Error state should print /sys/kernel/debug
>         ...
>     [danvet: split up long line.] <----- he did it
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I personally still believe we shouldn't chop up strings like this.

/me hides in shame

-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch