From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 4/6] drm/i915: enable VT switchless resume v2 Date: Mon, 18 Mar 2013 10:42:33 -0700 Message-ID: <20130318104233.0e74459d@jbarnes-desktop> References: <1361304703-2869-1-git-send-email-jbarnes@virtuousgeek.org> <1361304703-2869-5-git-send-email-jbarnes@virtuousgeek.org> <20130318074907.GK9021@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id C5C85E61A8 for ; Mon, 18 Mar 2013 10:42:38 -0700 (PDT) In-Reply-To: <20130318074907.GK9021@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 18 Mar 2013 08:49:07 +0100 Daniel Vetter wrote: > On Tue, Feb 19, 2013 at 12:11:41PM -0800, Jesse Barnes wrote: > > With the other bits in place, we can do this safely. > > > > v2: disable backlight on suspend to prevent premature enablement on resume > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/i915_drv.c | 12 +++++++++--- > > drivers/gpu/drm/i915/intel_fb.c | 3 +++ > > 2 files changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > > index c5b8c81..e76b038 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -492,9 +492,10 @@ static int i915_drm_freeze(struct drm_device *dev) > > > > cancel_delayed_work_sync(&dev_priv->rps.delayed_resume_work); > > > > - intel_modeset_disable(dev); > > As discussed in person last week, simply dropping this will probably kill > S0i3 support. Not really, since DPMS will be off in that case too generally, but it does make testing harder. I think it just needs to be a low level call to crtc disable on each pipe, otherwise we'll zap the state we're trying to save. -- Jesse Barnes, Intel Open Source Technology Center