From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] assembler: Add a regions visualizer tool
Date: Mon, 18 Mar 2013 16:04:42 +0000
Message-ID: <20130318160441.GA3390@dyon.amr.corp.intel.com>
References: <1363110781-27837-1-git-send-email-christopher.e.cummins@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id DCEC7E61B9
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 18 Mar 2013 09:04:46 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1363110781-27837-1-git-send-email-christopher.e.cummins@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Cummins <christopher.e.cummins@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Mar 12, 2013 at 05:53:01PM +0000, Chris Cummins wrote:
> This adds a html/js tool for visualizing GEN instruction source operand
> regions, similar to those used in the Programmer's Reference Manual. To
> use the tool, open the file assembler/gen_regions/gen_regions.html in
> your browser-of-preference.

To give more details about that work, there's nothing better than
examples, visualizing regions taken directly from the published IVB
documentation:

http://damien.lespiau.name/intel/gen_regions.html#execsize=16&region=g4.2<16;8,2>w&advanced=0

http://damien.lespiau.name/intel/gen_regions.html#execsize=16&region=r5.0<1;8,2>:w&advanced=0

A quick review trying to use the tool:

  * I think it'd be better if byte 0 is at the right, it seems to be the
    usual ways to represent registers, lower bits at the right.
  * there's a bug when giving advanced=1 on the URL, the tool doesn't
    seem to take it into account
  * it'd be nice to get rid of the trailing white space (no review would
    be complete without a mention to trailing white space, rule #1 of
    the open source world) from the imported js files, I usually use a
    script around:
    	sed -i -e 's,[ \t]*$,,' $file

-- 
Damien